cocci: Fix Python path for coccilib #24430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to run the coccinelle checks locally (with the coccicheck image
from DockerHub, or by rebuilding it locally) fails with the current
error:
Python error: No module named 'coccilib'
It so happens that it has also been failing silently in the CI for a
while! Logging in to the container, we can see:
bash-5.1$ python3
Python 3.10.4 (main, Apr 30 2022, 16:49:16) [GCC 11.2.1 20220219] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> print(sys.path)
['', '/usr/lib/python310.zip', '/usr/lib/python3.10', '/usr/lib/python3.10/lib-dynload', '/usr/lib/python3.10/site-packages']
bash-5.1$ find /usr -name 'coccilib'
/usr/local/lib/coccinelle/python/coccilib
This can be trivially addressed by adding the relevant module path to
the $PYTHONPATH environment variable in the Dockerfile.
The coccinelle checks used to work, but now fail on multiple branches.
The root cause for the issue is unknown at this time.
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
added
kind/bug/CI
ldelossa
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run the coccinelle checks locally (with the coccicheck image from DockerHub, or by rebuilding it locally) fails with the current error:
It so happens that it has also been failing silently in the CI for a while! Logging in to the container, we can see:
This can be trivially addressed by adding the relevant module path to the
$PYTHONPATHenvironment variable in the Dockerfile.The coccinelle checks used to work, but now fail on multiple branches. The root cause for the issue is unknown at this time.
This commit was split off of #24392, so we can merge the Dockerfile change, then generate a new image from the repo, and at last fix the script and coccinelle reports and update the image references (see initial PR). See also that PR as proof that setting
$PYTHONPATHdoes fix the issue.