Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator/cmd: add goleak check to TestOperatorHive #24431

Merged
merged 1 commit into from Mar 21, 2023
Merged

operator/cmd: add goleak check to TestOperatorHive #24431

merged 1 commit into from Mar 21, 2023

Conversation

tklauser
Copy link
Member

Add a goleak check the same way as in the daemon's TestAgentCell.

Reference: #24419 (review)
Suggested-by: Jussi Maki jussi@isovalent.com

@tklauser
operator/cmd: add goleak check to TestOperatorHive
77f459b 
Add a goleak check the same way as in the daemon's TestAgentCell.

Reference: #24419 (review)
Suggested-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. area/operator Impacts the cilium-operator component labels Mar 17, 2023
@tklauser tklauser requested a review from joamaki March 17, 2023 15:28
@tklauser tklauser requested a review from a team as a code owner March 17, 2023 15:28
@tklauser tklauser requested a review from squeed March 17, 2023 15:28
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 17, 2023
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Mar 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 17, 2023
@tklauser tklauser mentioned this pull request Mar 17, 2023
Merged
joamaki
joamaki approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Surprising this didn't require any extra ignores...

@tklauser
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@tklauser tklauser merged commit 0128717 into master Mar 21, 2023
42 checks passed
@tklauser tklauser deleted the pr/tklauser/hive-goleak-follow-up branch March 21, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
area/operator Impacts the cilium-operator component ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tklauser @squeed @joamaki