Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/stream: Simplify ToChannel usage #24432

Merged
merged 2 commits into from Mar 22, 2023
Merged

pkg/stream: Simplify ToChannel usage #24432

merged 2 commits into from Mar 22, 2023

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Mar 17, 2023

See individual commits.

@joamaki
stream: Simplify ToChannel sink
92cb3af 
Since we're going to mostly be creating streams that don't complete with an error,
make providing the error channel an option to ToChannel.

Clean up the hive/example/events.go to expose an Observable rather than just the
channel as with an observable the pkg/stream operators can be used directly.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki
pkg/node: Embed Observable in LocalNodeStore interface
44bd805 
This makes it explicit that the LocalNodeStore is an Observable.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki requested a review from jibi March 17, 2023 15:42
@joamaki joamaki requested review from a team as code owners March 17, 2023 15:42
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2023
@joamaki joamaki added the release-note/misc This PR makes changes that have no direct user impact. label Mar 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 17, 2023
@joamaki joamaki added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@joamaki
Copy link
Contributor Author

joamaki commented Mar 21, 2023

Marking ready as the pkg/stream tests pass. The changes to ToChannel only affected examples, so no need for full CI.

@borkmann borkmann merged commit cb45fed into cilium:master Mar 22, 2023
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jibi jibi jibi approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joamaki @jibi @borkmann