ingress: Avoid potential nil pointer during cleanup #24444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
As part of garbage collected steps in default Ingress class changes, the garbage collection process kicks off based on our translation logic. However, depending on which load-balancer mode is used, the translated service or endpoint might be nil. This commit is to make sure that we only performs GC if applicable. Ideally, only Service and Endpoint objs should be checked, but for readability, nil check for CEC object is also done. Fixes: 85671ad Fixes: cilium#24347 Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/ingress-cleanup
branch
from
a69f7db
to
ac3ac98
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/test-1.26-net-next |
mhofstetter
approved these changes
Mar 22, 2023
christarazi
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of garbage collected steps in default Ingress class changes, the garbage collection process kicks off based on our translation logic. However, depending on which load-balancer mode is used, the translated service or endpoint might be nil. This commit is to make sure that we only performs GC if applicable. Ideally, only Service and Endpoint objs should be checked, but for readability, nil check for CEC object is also done.
Fixes: 85671ad
Fixes: #24347
Notes
This is only happening in master branch but not 1.13 branch, so backport is not required.