docs: Deprecate CNPStatusUpdates/K8sEventHandover #24464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
marseel
added
the
release-note/minor
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Is there a larger issue or roadmap item for this deprecation? Anything with more context you can link to? |
marseel
force-pushed
the
deprecate_cnp_status_updates
branch
from
762d5a5
to
6c98b7f
Compare
squeed
requested changes
Mar 22, 2023
There was a problem hiding this comment.
One last request (sorry) -- can you add something in upgrade.rst about the deprecation?
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
@marseel any updates on this? |
github-actions
bot
removed
the
stale
marseel
force-pushed
the
deprecate_cnp_status_updates
branch
from
6c98b7f
to
62ab471
Compare
qmonnet
requested changes
May 31, 2023
marseel
force-pushed
the
deprecate_cnp_status_updates
branch
2 times, most recently
from
c90907f
to
3034500
Compare
squeed
approved these changes
Jun 1, 2023
|
/test |
2 similar comments
|
/test |
|
/test |
|
I would argue this change is trivial enough as to not require a full CI run. |
CNP Status Updates are known to cause scalability-related issues. Deprecate it in preparation to remove support in a future release, to minimize the maintenance burden of this code. Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
deprecate_cnp_status_updates
branch
from
3034500
to
dff1622
Compare
Marking as ready-to-merge as all basic CI tests passed. |
marseel
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNP Node status updates are known to cause scalability-related issues. Deprecate it in preparation to remove support in a future release, to minimize the maintenance burden of this code.
Related #24503