option: Skip NodeEncryptionOptOutLabels when marshalling to json
#24470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the value of `NodeEncryptionOptOutLabels` could not be unmarshalled from JSON because of it being an interface type. This resulted in the cilium-cli connectivity test setup to fail with the following error: ``` connectivity test failed: unmarshaling cilium runtime config json: json: cannot unmarshal array into Go struct field DaemonConfig.NodeEncryptionOptOutLabels of type labels.Selector ``` Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
the
release-note/misc
michi-covalent
approved these changes
Mar 20, 2023
bimmlerd
approved these changes
Mar 20, 2023
|
/test |
|
https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/1371/ looks like a variant of #24453 |
|
/test-1.25-4.19 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 20, 2023
Need cilium/cilium#24470 to fix this error that happens during cilium connectivity test setup: connectivity test failed: unmarshaling cilium runtime config json: json: cannot unmarshal array into Go struct field DaemonConfig.NodeEncryptionOptOutLabels of type labels.Selector Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 20, 2023
Need cilium/cilium#24470 to fix this error that happens during cilium connectivity test setup: connectivity test failed: unmarshaling cilium runtime config json: json: cannot unmarshal array into Go struct field DaemonConfig.NodeEncryptionOptOutLabels of type labels.Selector Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
Need cilium#24470 to fix this error that happens during cilium connectivity test setup: connectivity test failed: unmarshaling cilium runtime config json: json: cannot unmarshal array into Go struct field DaemonConfig.NodeEncryptionOptOutLabels of type labels.Selector Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the value of
NodeEncryptionOptOutLabelscould not be unmarshalled from JSON because of it being an interface type.This resulted in the cilium-cli connectivity test setup to fail with the following error: