Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: quarantine K8sAgentIstioTest #24476

Merged
merged 1 commit into from Mar 22, 2023

Conversation

nbusseneau
Copy link
Member

This test has been consistently failing since March 10 on Kernel 4.19 pipelines for K8s 1.17 - 1.24.

Since we are considering deprecating the Istio integration (#24204), we quarantine the test as it's unclear if we should invest in understanding the issue and fixing it.

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on legit failure. Seems like a matter of defining an inline func () { ... }

This test has been consistently failing since March 10 on Kernel 4.19
pipelines for K8s 1.17 - 1.24.

Since we are considering deprecating the Istio integration
(cilium#24204), we quarantine the test
as it's unclear if we should invest in understanding the issue and
fixing it.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau
Copy link
Member Author

🤦🏻‍♂️ Yes, correct. Not sure why it wasn't picked up by my local environment, it seems like I broke something and now nothing gets analysed.

@nbusseneau
Copy link
Member Author

/test

@nbusseneau
Copy link
Member Author

nbusseneau commented Mar 20, 2023

/test-missed-k8s

Job 'Cilium-PR-K8s-1.24-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathVerifier Runs the kernel verifier against Cilium's BPF datapath

Failure Output

FAIL: terminating containers are not deleted after timeout

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-4.19 so I can create one.

@nbusseneau
Copy link
Member Author

Various flakes / Vagrant provisioning issue were hit, but it's fine, I only wanted to check if Istio tests were indeed quarantined from the intended jobs, and they are.

Marking ready to merge.

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@youngnick youngnick merged commit bef5bfc into cilium:master Mar 22, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants