Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: include @cilium/sig-datapath for all datapath specific CI changes #24487

Merged
merged 1 commit into from Mar 21, 2023

Conversation

tklauser
Copy link
Member

Namely this covers .github/workflows/tests-datapath-verifier.yaml which should also be reviewed by a member of @cilium/sig-datapath.

… changes

Namely this covers .github/workflows/tests-datapath-verifier.yaml which
should also be reviewed by a member of @cilium/sig-datapath.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Mar 21, 2023
@tklauser tklauser requested a review from a team March 21, 2023 08:12
@tklauser tklauser requested a review from a team as a code owner March 21, 2023 08:12
@tklauser tklauser requested a review from bimmlerd March 21, 2023 08:12
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's just hope we don't start calling them -dp- or something 😅

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@qmonnet
Copy link
Member

qmonnet commented Mar 21, 2023

let's just hope we don't start calling them -dp- or something sweat_smile

Theoretically, we should catch it (I mean, if we renamed them all)

- name: Check if CODEOWNERS has stale entries

@joestringer joestringer merged commit b8f09b4 into master Mar 21, 2023
42 of 43 checks passed
@joestringer joestringer deleted the pr/tklauser/codeowners-datapath-ci branch March 21, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants