bpf, datapath: unconditionally assume support for direct access to map values #24504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
sig/datapath
|
/test |
tklauser
force-pushed
the
pr/tklauser/bpf-direct-access-to-map
branch
from
0d045c6
to
4009cd7
Compare
…p values Map helpers are allowed to access map values directly since kernel version 4.18 [1], [2]. For Cilium v1.14, the minimum required kernel version is 4.19.57 [4]. Thus we can now unconditionally assume support for direct access to map values. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d71962f3e627b5941804036755c844fabfb65ff5 [2] https://github.com/iovisor/bcc/blob/master/docs/kernel-versions.md#main-features [3] https://docs.cilium.io/en/latest/operations/system_requirements/#base-requirements For #22116 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/bpf-direct-access-to-map
branch
from
4009cd7
to
ceae2f5
Compare
|
/test |
|
Thanks for the review.
That check is not marked as required, so I'd probably only update the commit message and re-push in case there are other review comments to address.
Thanks for the pointer. |
borkmann
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map helpers are allowed to access map values directly since kernel version 4.18 [1], [2].
For Cilium v1.14, the minimum required kernel version is 4.19.57 [4]. Thus we can now unconditionally assume support for direct access to map values.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d71962f3e627b5941804036755c844fabfb65ff5
[2] https://github.com/iovisor/bcc/blob/master/docs/kernel-versions.md#main-features
[3] https://docs.cilium.io/en/latest/operations/system_requirements/#base-requirements
For #22116