Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CI test for node-local-dns with LRP #24508

Open
Weil0ng opened this issue Mar 21, 2023 · 1 comment
Open

Create CI test for node-local-dns with LRP #24508

Weil0ng opened this issue Mar 21, 2023 · 1 comment
Assignees
Labels
area/lrp Impacts Local Redirect Policy. needs/e2e-test This issue is not covered by existing CI tests, but should be.
Milestone

Comments

@Weil0ng
Copy link
Contributor

Weil0ng commented Mar 21, 2023

This is a follow up item from #24230 , we need to add a CI test to cover node-local-dns use case, need to check:

  • DNS traffic correctly hits node-cache (incrementing its counter) and getting resolved
  • Traffic between client pod and node-cache is NOT tracked in kernel conntrack table
@Weil0ng Weil0ng added the needs/e2e-test This issue is not covered by existing CI tests, but should be. label Mar 21, 2023
@Weil0ng Weil0ng added this to the 1.14 milestone Mar 21, 2023
@aditighag aditighag added the area/lrp Impacts Local Redirect Policy. label Mar 30, 2023
@aditighag
Copy link
Member

Slack messages roll over, so copy pasting the messages here -

We can add a new test to the suite in cilium-cli - https://github.com/cilium/cilium-cli/tree/main/connectivity/tests. We could use the same test pods deployed in the guide. We would have to add the lrp feature flag detection - https://github.com/cilium/cilium-cli/blob/main/connectivity/check/features.go.

@Weil0ng We discussed having a plan of action on the original linked PR - #24230 (comment). Given the PR was merged with the expectation that we'll add CI coverage in 1.14. Feel free to follow-up on the Slack thread or here in case you have any questions regarding the test framework before getting started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lrp Impacts Local Redirect Policy. needs/e2e-test This issue is not covered by existing CI tests, but should be.
Projects
None yet
Development

No branches or pull requests

2 participants