clustermesh: remote services handling misc improvements #24515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/clustermesh
giorio94
requested review from
aspsk,
youngnick,
YutaroHayakawa,
squeed and
nathanjsweet
|
/test |
YutaroHayakawa
approved these changes
Mar 23, 2023
squeed
reviewed
Mar 23, 2023
nathanjsweet
requested changes
Mar 24, 2023
nathanjsweet
approved these changes
Mar 27, 2023
giorio94
force-pushed
the
mio/service-cache-misc
branch
from
13618c7
to
38bb008
Compare
giorio94
force-pushed
the
mio/service-cache-misc
branch
from
38bb008
to
48f0011
Compare
|
I've added the blocked label since it requires to be rebased on top of #24619 once that one is merged (one integration test would fail otherwise). |
Previously, we filtered events received from remote services observers based on the IncludeExternal and Shared flags. This commit changes the logic to consider only the Shared flag, which is more idiomatic (since IncludeExternal takes only effect in the local cluster). No behavioral change is introduced though, since a non-global service cannot be shared. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Currently, we identify services using name + namespace. This commit extends the ID to possibly include also the cluster name, and adapts the related external service merging logic to account for its presence. The ServiceID with empty cluster name is reserved for backward compatibility. Co-authored-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com> Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Expose the cluster name as part of the service metadata, in case it does not match the one of the local cluster. Then, the CLI can use that to output a more informative status. Note: the CLI currently relies on the cluster name not being set if the service is local, since it does not know the local cluster name). Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Extend the service cache to specify additional mutators to be executed when a service is received from k8s and converted to the internal representation. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/service-cache-misc
branch
from
48f0011
to
b353041
Compare
giorio94
removed
the
dont-merge/blocked
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
The integration tests failed due to a new flake: #24652 |
|
/test-1.24-5.4 Hit known flake #16122 |
aspsk
approved these changes
Mar 31, 2023
squeed
approved these changes
Apr 3, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, refer to the individual commit messages for the details about the respective changes.