Fix some test failures for bpf_nat_test.c #24534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutaroHayakawa
added
kind/bug/CI
This test is affected by coverbee's bug. Add it to the exclude pattern. cilium/coverbee#7 Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/exclude-bpf-nat
branch
from
41ec8a7
to
053a172
Compare
YutaroHayakawa
changed the title
YutaroHayakawa
force-pushed
the
yutaro/exclude-bpf-nat
branch
from
a879be3
to
ac8e191
Compare
Coccicheck pointed out following * file ./tests/bpf_nat_tests.c: missing __align_stack_8 on icmphdr on line 56 * file ./tests/bpf_nat_tests.c: missing __align_stack_8 on inner_l4 on line 114 * file ./tests/bpf_nat_tests.c: missing __align_stack_8 on in_l4hdr on line 431 Fix them by adding missing __align_stack_8. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
force-pushed
the
yutaro/exclude-bpf-nat
branch
from
ac8e191
to
a103dad
Compare
YutaroHayakawa
added
the
dont-merge/preview-only
|
BPF Unit Test and Cocchicheck recovered. Once reviews are in, I'll revert the preview commit. |
YutaroHayakawa
changed the title
YutaroHayakawa
changed the title
brlbil
approved these changes
Mar 23, 2023
gentoo-root
approved these changes
Mar 23, 2023
YutaroHayakawa
force-pushed
the
yutaro/exclude-bpf-nat
branch
from
a103dad
to
f47ab90
Compare
YutaroHayakawa
removed
the
dont-merge/preview-only
|
Reverted preview commit. Modified tests were passed, and reviews are in. I don't think it does make sense to run e2e tests since we only have changes to BPF Check related code. |
YutaroHayakawa
added
the
ready-to-merge
sahid
approved these changes
Mar 23, 2023
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two test failures on the latest master.
BPF Unit Test failure for bpf_nat_test.c
#24212 introduces a known bug of Coverbee into the code base (cilium/coverbee#7). This only becomes a problem when we run the test with the affected code (the code includes
nat.horconntrack_map.h). We introduced the feature to disable coverage report per file to prevent CI from failing. The latest exclusion pattern is also introduced in #24212 (9a274db).Yesterday, we merged the PR that introduces a new test file affected by the bug #18414 (07edf55), but we couldn't notice that because the BPF Unit test CI ran without the change introduced in #24212.
Coccicheck failure for bpf_nat_test.c
#24392 "fixed" the Coccicheck, which was not running correctly for a while. This was merged on May 21st. #18414 introduced the code which fails with Coccicheck but ran the check on May 20th, which was before the fix merged. That's why we couldn't notice the failure before the merge.