New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/kind: no longer create local docker registry #24541
Conversation
Now that we use `kind load docker-image`, it's not necessary to push images to a local registry as well. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool! small nit about the image names
@@ -5,9 +5,11 @@ debug: | |||
enabled: true | |||
image: | |||
override: "localhost:5000/cilium/cilium-dev:local" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit confusing to still have these referring to localhost:5000 without that being an actual registry, can we do something about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to decide what to do; by default, the built images have the tag quay.io/cilium/cilium-dev:local
. As long as there's no chance of someone accidentally pushing that image to quay, we could keep it. Otherwise, some sort of unpushable tag would be better.
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment |
I seem to recall some datapath tests relying on the local registry, but I can't actually find it in the codebase. Let's see if the tests pass :-) |
Manually marking as ready-to-merge, since the only failing tests don't even use kind. Tophat, feel free to disagree. |
Now that we use
kind load docker-image
, it's not necessary to push images to a local registry as well.