Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/kind: no longer create local docker registry #24541

Merged
merged 1 commit into from Mar 30, 2023

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Mar 23, 2023

Now that we use kind load docker-image, it's not necessary to push images to a local registry as well.

Now that we use `kind load docker-image`, it's not necessary to push
images to a local registry as well.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed added the release-note/ci This PR makes changes to the CI. label Mar 23, 2023
@squeed squeed requested review from a team as code owners March 23, 2023 11:58
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! small nit about the image names

@@ -5,9 +5,11 @@ debug:
enabled: true
image:
override: "localhost:5000/cilium/cilium-dev:local"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit confusing to still have these referring to localhost:5000 without that being an actual registry, can we do something about that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to decide what to do; by default, the built images have the tag quay.io/cilium/cilium-dev:local. As long as there's no chance of someone accidentally pushing that image to quay, we could keep it. Otherwise, some sort of unpushable tag would be better.

@squeed
Copy link
Contributor Author

squeed commented Mar 30, 2023

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Tests NodePort inside cluster (kube-proxy) with IPSec and externalTrafficPolicy=Local

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:32569 failed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@squeed
Copy link
Contributor Author

squeed commented Mar 30, 2023

I seem to recall some datapath tests relying on the local registry, but I can't actually find it in the codebase. Let's see if the tests pass :-)

@squeed
Copy link
Contributor Author

squeed commented Mar 30, 2023

Test failures are unrelated; GKE failed to start up (doesn't use kind) and a known flake -- #24648

@squeed
Copy link
Contributor Author

squeed commented Mar 30, 2023

Manually marking as ready-to-merge, since the only failing tests don't even use kind. Tophat, feel free to disagree.

@squeed squeed added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2023
@julianwiedmann julianwiedmann added the area/CI Continuous Integration testing issue or flake label Mar 30, 2023
@julianwiedmann julianwiedmann merged commit 2975c75 into cilium:master Mar 30, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants