Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update masquerading.rst to reflect new support for icmp #24556

Merged
merged 1 commit into from Mar 25, 2023
Merged

doc: update masquerading.rst to reflect new support for icmp #24556

merged 1 commit into from Mar 25, 2023

Conversation

sahid
Copy link
Member

@sahid sahid commented Mar 24, 2023

This is to reflect the new support of ICMP DestUnreach need-to-frag.

@sahid sahid requested a review from a team as a code owner March 24, 2023 08:59
@sahid sahid requested a review from qmonnet March 24, 2023 08:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 24, 2023
qmonnet
qmonnet requested changes Mar 24, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Some comments below.

Documentation/network/concepts/masquerading.rst Outdated Show resolved Hide resolved
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 24, 2023
@sahid sahid requested a review from qmonnet March 24, 2023 09:41
@sahid
doc: update masquerading.rst to reflect new support for icmp
99e03ee 
This is to reflect the new support of ICMP DestUnreach need-to-frag.

Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com>
qmonnet
qmonnet approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 24, 2023
@youngnick youngnick merged commit 0253771 into cilium:master Mar 25, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sahid @qmonnet @youngnick