New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datapath/linux/route: fix CI expectations for rule string format #24577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When CI is running it expects the fib rule format without the new protocol, so it breaks when matching the string formats with the expected ones. Fix it by adding the protocol. Fixes: d0cca9d ("datapath/linux/route: add support for rule protocol") Signed-off-by: Nikolay Aleksandrov <nikolay@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 27, 2023
pchaigno
approved these changes
Mar 27, 2023
pchaigno
approved these changes
Mar 27, 2023
pchaigno
added
area/CI
Continuous Integration testing issue or flake
release-note/ci
This PR makes changes to the CI.
labels
Mar 27, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 27, 2023
I believe this can be merged without running the full CI as the changes are very limited in scope and they fix a CI job that is currently consistently failing. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 27, 2023
7 tasks
pchaigno
added
the
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
label
Mar 27, 2023
I've added the backport label for v1.13 here given the PR is fixes is planned for backport into 1.13. |
tklauser
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Mar 28, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
Mar 28, 2023
tklauser
added
affects/v1.11
This issue affects v1.11 branch
affects/v1.12
This issue affects v1.12 branch
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
affects/v1.13
This issue affects v1.13 branch
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Mar 30, 2023
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Needs backport from master
in 1.13.2
Mar 30, 2023
jibi
removed
affects/v1.11
This issue affects v1.11 branch
affects/v1.12
This issue affects v1.12 branch
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
affects/v1.13
This issue affects v1.13 branch
labels
Apr 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CI is running it expects the fib rule format without the new protocol, so it breaks when matching the string formats with the expected ones. Fix it by adding the protocol.
Fixes: d0cca9d ("datapath/linux/route: add support for rule protocol")