clustermesh: fix client usage when setting the cluster configuration #24591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the SetClusterConfig function always used the default kvstore client to update the cluster configuration, neglecting the one specified as parameter. This commit fixes it. Fixes: b24973e ("clustermesh: Add helper functions to set/get cluster configuration") Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
area/clustermesh
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/test-1.26-net-next Hit known flake #22579 |
|
/test-1.26-net-next Hit #24573 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the SetClusterConfig function always used the default kvstore client to update the cluster configuration, neglecting the one specified as parameter. This PR fixes it.
I've not currently marked this PR for backport, since this is not a user-facing bug. Indeed, all callers of that function specify the default client as parameter.