bpf: fixes for IPv6 revNAT #24610
Merged
bpf: fixes for IPv6 revNAT #24610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipv6_hdrlen_offset() can return an error, handle it. Fixes: 156c30e ("bpf/nat: implement support of ICMP6 Error packet too big") Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When peaking into the inner packet, extract the .nexthdr type into the CT tuple. This is what we later use in the switch-statement to handle the inner L4 protocol type. If the inner packet contains IPv6 extension headers, we would currently misidentify the first extension type as L4 protocol type and return DROP_INVALID. Fixes: 156c30e ("bpf/nat: implement support of ICMP6 Error packet too big") Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When we don't recognize the inner L4 protocol type of an ICMPV6_PKT_TOOBIG packet, return the appropriate drop reason. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
kind/bug
|
/test |
sahid
approved these changes
Mar 29, 2023
YutaroHayakawa
approved these changes
Mar 29, 2023
|
K8sDatapathConfig Host firewall With VXLAN flaked with #15455 |
julianwiedmann
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some minor fallout from #18414.