Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a hint about using Vagrant on Apple Silicon #24626

Merged
merged 1 commit into from Mar 30, 2023
Merged

Add a hint about using Vagrant on Apple Silicon #24626

merged 1 commit into from Mar 30, 2023

Conversation

brandshaide
Copy link
Contributor

@brandshaide brandshaide commented Mar 29, 2023 •
edited

According to official information, Oracle won't provide official support for Apple M1/M2, so I've added a minor hint in order to raise awareness on this topic for contributors working on Apple silicon.

@brandshaide brandshaide requested review from a team as code owners March 29, 2023 11:41
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 29, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 29, 2023
@bimmlerd bimmlerd added the release-note/misc This PR makes changes that have no direct user impact. label Mar 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 29, 2023
Add a hint about using Vagrant on Apple Silicon
8250ce5 
Signed-off-by: Philipp Gniewosz <philipp.gniewosz@posteo.de>
bimmlerd
bimmlerd approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

qmonnet
qmonnet approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 30, 2023
@julianwiedmann julianwiedmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Mar 30, 2023
@julianwiedmann julianwiedmann merged commit 8c6ff82 into cilium:master Mar 30, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bimmlerd bimmlerd bimmlerd approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brandshaide @bimmlerd @qmonnet @julianwiedmann