Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixing typo in description of label release-note/ci #24665

Merged
merged 1 commit into from Mar 31, 2023
Merged

docs: Fixing typo in description of label release-note/ci #24665

merged 1 commit into from Mar 31, 2023

Conversation

mhofstetter
Copy link
Member

This is a CI feature of bug fix.

->

This is a CI feature or bug fix.

of -> or.

i assume this was the intention of the author 馃檹

@mhofstetter
docs: Fixing typo in description of label release-note/ci
9d23f38 
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter requested review from a team as code owners March 31, 2023 07:05
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 31, 2023
@mhofstetter mhofstetter added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 31, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 31, 2023
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 31, 2023
@julianwiedmann
Copy link
Member

@mhofstetter mind failing a CI issue for the Travis flake (FAIL package: github.com/cilium/cilium/clustermesh-apiserver) ? 馃檹

@julianwiedmann julianwiedmann merged commit 0939e40 into cilium:master Mar 31, 2023
34 of 35 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/release-note-ci-typo branch March 31, 2023 08:22
@mhofstetter mhofstetter mentioned this pull request Mar 31, 2023
Closed
@mhofstetter
Copy link
Member Author

mhofstetter commented Mar 31, 2023 •
edited

@mhofstetter mind failing a CI issue for the Travis flake (FAIL package: github.com/cilium/cilium/clustermesh-apiserver) ? pray

@julianwiedmann Sure: #24668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@bimmlerd bimmlerd Awaiting requested review from bimmlerd bimmlerd was automatically assigned from cilium/contributing

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhofstetter @julianwiedmann @pchaigno