bpf: small CT cleanups #24686
Merged
bpf: small CT cleanups #24686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite a few fields in the ct_state struct are not relevant to CT entries created with CT_SERVICE. Ignore them, for both the entry creation and when returning the result of a CT lookup. This is mostly a readability improvement, I'm not aware that it's helping with any complexity troubles. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
lb*_local() always calls ct_create*() with these three parameters set to `false`. So it's safe to ignore them for CT_SERVICE entries. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When bpf_lxc does a CT_SERVICE lookup, it propagates the result across the subsequent tail-call with lb*_ctx_store_state() and restores it afterwards for use by the ct_create(..., CT_EGRESS) call. This currently propagates the backend_id (as returned by the CT_SERVICE lookup). As ct_create*(..., CT_EGRESS) ignores ct_state->backend_id, this isn't necessary. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
|
opened #24687 for the |
|
/test-1.26-net-next |
|
@YutaroHayakawa hoping you still have some context on this 🙂 |
julianwiedmann
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the semantics of some field in the ct_entry / ct_state struct. Callers of lb_local() re-use the result of the
CT_SERVICElookup (or parts of it), so it's important to understand which fields are relevant and which ones are guaranteed to be 0.We started to pay more attention to this in #24212, let's now also clean up the backlog of existing fields.