Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: group golangci-lint updates #24688

Merged

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Apr 3, 2023

Currently, the golangci-lint update does not contain the update in the GH action files. The reason is a packageRule which combines and schedules all GH action version updates.

This commit introduces the necessary grouping packageRule which combines all golangci-lint updates over all files.

Being further down in the list of package rules, this one gets selected.

the result of a dry-run results in the following result

DEBUG: 2 file(s) to commit (repository=mhofstetter/cilium, baseBranch=master, branch=renovate/master-golangci-lint)
 INFO: DRY-RUN: Would commit files to branch renovate/master-golangci-lint (repository=mhofstetter/cilium, baseBranch=master, branch=renovate/master-golangci-lint)

Initial PR: #24664
Automated Renovate PR (with missing update in GH action): #24682

@mhofstetter mhofstetter added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Apr 3, 2023
@mhofstetter mhofstetter requested a review from a team as a code owner April 3, 2023 06:36
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, comment nit

.github/renovate.json5 Outdated Show resolved Hide resolved
Currently, the golangci-lint update does not contain the update in
the GH action files. The reason is a packageRule which
combines and schedules all GH action version updates.

This commit introduces the necessary grouping packageRule which
combines all golangci-lint updates over all files.

Being further down in the list of package rules, this one gets selected.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/renovate-golangcilint-group branch from 0a6ed2a to 6c6f7a9 Compare April 3, 2023 08:17
@mhofstetter
Copy link
Member Author

error in travis seems to be a flake -> filed a CI flake issue.

adding label ready-to-merge as this change doesn't need additional tests.

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 3, 2023
@squeed squeed merged commit bc993ec into cilium:master Apr 3, 2023
42 of 43 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/renovate-golangcilint-group branch April 3, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants