CI / Kind enhancements #24714
Merged
CI / Kind enhancements #24714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
kind/bug/CI
Knowing which kind command we are actually executing is useful for reproducibility without using the kind.sh script. Signed-off-by: André Martins <andre@cilium.io>
The current implementation of isTestFocused is only checking for the FocusString. This causes some bugs in the test runs such as the miss of some "AfterAll" executions since the ref count of all "AfterEach"es is used by taking into account how many tests will be executed. Checking how many tests will be executed is done by checking if a particular test is "focused", when using a skip string, and the test matches the test name, the test should not be marked as focused. Signed-off-by: André Martins <andre@cilium.io>
unzip uses more resources than tar so we should us tar instead. Signed-off-by: André Martins <andre@cilium.io>
Certain tests are relying on the node name while others are relying on node labels. This commit fixes the uses of relying on the node name. Signed-off-by: André Martins <andre@cilium.io>
The current egress-ip-deployment requires a VM to have a specific interface name. Instead, always use the interface for outside traffic. Signed-off-by: André Martins <andre@cilium.io>
This resource was missing from the list of Cilium components that should have been deleted. Signed-off-by: André Martins <andre@cilium.io>
The "192.168.56.13" IP address might not be always available on all clusters. With this commit we will regenerate a manifest that uses the IP addresses of the node instance running without Cilium, which will make the test run on environments that are not specific to clusters with the IP address "192.168.56.13". Signed-off-by: André Martins <andre@cilium.io>
This taint should also be removed from all nodes since we want to use all nodes for CI purposes. Signed-off-by: André Martins <andre@cilium.io>
|
/test |
jibi
approved these changes
Apr 4, 2023
tklauser
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a list of small bug fixes / enhancements done in our ginkgo and kind code base. Best if reviewed by commit basis.