Pass error codes from map_update_elem (ct_create) to drop notifications #24716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gentoo-root
commented
Apr 3, 2023
•
gentoo-root
commented
gentoo-root
added
release-note/minor
gentoo-root
force-pushed
the
ct_fill_up-ext_err
branch
6 times, most recently
from
2fdc5b8
to
d546948
Compare
|
/test |
|
/test-1.26-net-next |
pchaigno
approved these changes
Apr 7, 2023
|
I think a rebase will fix the net-next failures. Then we should be good to merge. |
gentoo-root
force-pushed
the
ct_fill_up-ext_err
branch
from
d546948
to
040c6f7
Compare
|
#24410 merged yesterday, so a rebase is needed here :-) |
Whenever map_update_elem fails in ct_create{4,6}, pass its return code
upwards via ext_err.
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
Start passing the new ext_err parameter to ct_create4 and ct_create6
everywhere where possible. Expose the kernel error code returned by
map_update_elem to drop notifications.
As a side effect, ext_err set by policy_can_access_ingress in
ipv{4,6}_host_policy_egress is now also passed to the caller and the
drop notification.
Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
gentoo-root
force-pushed
the
ct_fill_up-ext_err
branch
from
040c6f7
to
5918641
Compare
|
/test |
julianwiedmann
added a commit
to julianwiedmann/cilium
that referenced
this pull request
Aug 23, 2023
[ upstream commit 1f6c10d ] [ backporter's notes: as cilium#24716 is missing, manually add the needed ext_err bits into nat.h and switch the callers to send_drop_notify_error_ext(). ] snat_*_nat_handle_mapping() already takes an *ext_err parameter to pass up detailed error information from its CT logic. Use this to also report errors from map_update_elem() when creating the NAT entries. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added a commit
to julianwiedmann/cilium
that referenced
this pull request
Aug 23, 2023
[ upstream commit 66e9579 ] [ backporter's notes: as cilium#24716 is missing, do the switch to send_drop_notify_error_ext() ] tail_nodeport_dsr_ingress_ipv*() already maintains an *ext_err parameter to report detailed error information from its CT logic. Use this to also report errors from map_update_elem() when creating the RevDNAT entry. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
1 task
joestringer
pushed a commit
that referenced
this pull request
Aug 25, 2023
[ upstream commit 1f6c10d ] [ backporter's notes: as #24716 is missing, manually add the needed ext_err bits into nat.h and switch the callers to send_drop_notify_error_ext(). ] snat_*_nat_handle_mapping() already takes an *ext_err parameter to pass up detailed error information from its CT logic. Use this to also report errors from map_update_elem() when creating the NAT entries. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
Aug 25, 2023
[ upstream commit 66e9579 ] [ backporter's notes: as #24716 is missing, do the switch to send_drop_notify_error_ext() ] tail_nodeport_dsr_ingress_ipv*() already maintains an *ext_err parameter to report detailed error information from its CT logic. Use this to also report errors from map_update_elem() when creating the RevDNAT entry. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.