hubble: improve hubble lost event log rate limit #24720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
kind/enhancement
rolinh
approved these changes
Apr 4, 2023
pchaigno
approved these changes
Apr 4, 2023
Once we start logging the "hubble events queue is full" message, it means the buffered channel is full and the consumer can't keep up. From there either: * the consumer catches up and we stop logging the message * the consumer stay behind and we (rate-limited) log the message every time an event is read The latter case is not ideal because we think the consumer has caught up every time it reads a message while it stays behind. Since we now have metrics for Hubble lost events, a single message every 30s should be a useful enough signal from the logs. Signed-off-by: Alexandre Perrin <alex@isovalent.com> Suggested-by: Paul Chaignon <paul@cilium.io>
kaworu
force-pushed
the
pr/kaworu/hubble/rate-limit-lost-events
branch
from
c25ab08
to
8364e95
Compare
chancez
approved these changes
Apr 4, 2023
|
I don't think we need to run the full end-to-end tests for such minor changes. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we start logging the "hubble events queue is full" message, it means the buffered channel is full and the consumer can't keep up. From there either:
The latter case is not ideal because we think the consumer has caught up every time it reads a message while it stays behind. Since we now have metrics for Hubble lost events, a single message every 30s should be a useful enough signal from the logs.