Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: add packageRule group for cilium-cli #24725

Merged
merged 1 commit into from Apr 4, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 4, 2023

Add a new packageRule group for the cilium-cli dependency. This makes sure cilium-cli updates occur in a dedicated PR rather than being grouped with other GitHub action dependency updates. This is useful to allow manual testing by the reviewer.

Example PR: tklauser#501

/cc @nbusseneau

@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 4, 2023
@tklauser tklauser requested a review from a team as a code owner April 4, 2023 08:58
@tklauser tklauser requested a review from bimmlerd April 4, 2023 08:58
Add a new packageRule group for the cilium-cli dependency. This makes
sure cilium-cli updates occur in a dedicated PR rather than being
grouped with other GitHub action dependency updates. This is useful to
allow manual testing by the reviewer.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/renovate-group-cilium-cli branch from d4ffc55 to d5a2fe1 Compare April 4, 2023 09:10
"groupName": "Cilium CLI",
"groupSlug": "cilium-cli",
"matchDepNames": [
"cilium/cilium-cli"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hubble cli below also matches on quay.io/cilium/hubble - do we need the same for cilium cli?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently don't use (or provide) any stable docker images for cilium-cli, so I don't think such an entry is needed.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 4, 2023
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ;)

@squeed squeed merged commit 57b4727 into master Apr 4, 2023
43 checks passed
@squeed squeed deleted the pr/tklauser/renovate-group-cilium-cli branch April 4, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants