daemon: remove deprecated force-local-policy-eval-at-source option #24727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/daemon
|
/test |
|
/test-runtime hit #23997: https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/5875/ |
tklauser
force-pushed
the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
from
64f219e
to
47f8b6a
Compare
|
/test |
zacharysarah
approved these changes
Apr 4, 2023
aspsk
requested changes
Apr 5, 2023
tklauser
force-pushed
the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
from
47f8b6a
to
cebddcd
Compare
|
/test |
aspsk
approved these changes
Apr 5, 2023
pchaigno
approved these changes
Apr 5, 2023
thorn3r
approved these changes
Apr 5, 2023
nathanjsweet
approved these changes
Apr 5, 2023
tklauser
force-pushed
the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
from
cebddcd
to
5669fb7
Compare
|
/test |
tklauser
force-pushed
the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
from
5669fb7
to
3143381
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/1752/ If it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/test-1.26-net-next hit #15455 https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/1752/ |
|
Reviews are in and all CI except for ci-eks passed. That one is a known failure that got fixed on |
tklauser
added
the
ready-to-merge
tklauser
force-pushed
the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
from
3143381
to
be8a45d
Compare
tklauser
removed
the
ready-to-merge
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-5.4/1720/ If it is a flake and a GitHub issue doesn't already exist to track it, comment |
Following its deprecation in commit 0ded29b ("daemon: Deprecate force-local-policy-eval-at-source") for Cilium v1.13, remove it for Cilium v1.14. Keep the FORCE_LOCAL_POLICY_EVAL_AT_SOURCE macro defined in bpf code only, as this will still be needed by upcoming changes. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
from
be8a45d
to
70059b3
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
deleted the
pr/tklauser/drop-deprecated-force-local-policy-eval-at-source
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following its deprecation in commit 0ded29b ("daemon: Deprecate force-local-policy-eval-at-source") for Cilium v1.13, remove it for Cilium v1.14.
Keep the FORCE_LOCAL_POLICY_EVAL_AT_SOURCE macro defined in bpf code only, as this will still be needed by upcoming changes.
Ref. #15452