bpf: simplify adding/removing types to alignchecker #24736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aspsk
added
the
release-note/misc
YutaroHayakawa
approved these changes
Apr 4, 2023
Happy that you were chosen for the review :-) |
|
This PR doesn't require to run the testsuite, as cilium would already fail by this moment if |
aspsk
added
the
ready-to-merge
pchaigno
removed
the
ready-to-merge
pchaigno
requested changes
Apr 4, 2023
Types in alignchecker were listed like 'TYPE _n', e.g., 'struct tunnel_key _53', so this was simple to add a new type: just add 1 to the last n. However, this is not obvious what to do when removing a type: to re-enumerate the remaining types or to leave holes? Fix this by using the __COUNTER__ macro. Now a new type can be listed as _(TYPE), e.g., '_(struct tunnel_key)', so this simple both to add and to remove types. Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
aspsk
force-pushed
the
aspsk/pr/simplify-alignchecker
branch
from
b52cb9e
to
bea74a9
Compare
pchaigno
approved these changes
Apr 4, 2023
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types in alignchecker were listed like
TYPE _n, e.g.,struct tunnel_key _53, so this was simple to add a new type: just add 1 to the last n. However, this is not obvious what to do when removing a type: to re-enumerate the remaining types or to leave holes? Fix this by using the__COUNTER__macro. Now a new type can be listed as_(TYPE), e.g.,_(struct tunnel_key), so this simple both to add and to remove types.