Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enable load balancer acceleration for some datapath conformance cases #24738

Merged
merged 2 commits into from Apr 5, 2023

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Apr 4, 2023

gh/workflows: enable loadBalancer acceleration for some suites

Set loadBalancer.acceleration=testing-only in two datapath
conformance tests. I had originally planned to modify 12-15 but
those have encryption enabled. Instead, enable it on 6-7. Compared
to Jenkins we drop  testing for (EP routes=true,
acceleration=testing-only) from the matrix.

Updates #24151

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>

gh/workflows: fix initialization of EGRESS_GATEWAY

Use the same logic for EGRESS_GATEWAY as for other features.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
Enable loadBalancer.acceleration=testing-only in some datapath conformance cases

Use the same logic for EGRESS_GATEWAY as for other features.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb added release-note/ci This PR makes changes to the CI. feature/egress-gateway Impacts the egress IP gateway feature. ci/hyperjump labels Apr 4, 2023
@lmb lmb force-pushed the pr/lmb/ci-datapath-enable-acceleration-testing-only branch from c0446aa to ae0ed75 Compare April 4, 2023 16:03
@lmb
Copy link
Contributor Author

lmb commented Apr 4, 2023

@lmb lmb force-pushed the pr/lmb/ci-datapath-enable-acceleration-testing-only branch from ae0ed75 to 3078784 Compare April 4, 2023 16:34
@lmb lmb marked this pull request as ready for review April 4, 2023 16:34
@lmb lmb requested review from a team as code owners April 4, 2023 16:34
@lmb lmb requested review from gentoo-root and brlbil April 4, 2023 16:34
@lmb
Copy link
Contributor Author

lmb commented Apr 4, 2023

cc @jibi @brb

@lmb
Copy link
Contributor Author

lmb commented Apr 5, 2023

ConformanceK8sKind flaked: #24622

Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-run the flaky test, and it passed.
LGTM from the workflow perspective.

Copy link
Member

@jibi jibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you maybe add some quick context to the second commit on how we ended up with 6-7? (iirc the initial idea was 4-7 and 12-15, which are the ones with egressgw enabled but 12-15 have encryption enabled?)

@lmb lmb force-pushed the pr/lmb/ci-datapath-enable-acceleration-testing-only branch from 3078784 to ae56776 Compare April 5, 2023 12:50
Set loadBalancer.acceleration=testing-only in two datapath
conformance tests. I had originally planned to modify 12-15 but
those have encryption enabled. Instead, enable it on 6-7. Compared
to Jenkins we drop  testing for (EP routes=true,
acceleration=testing-only) from the matrix.

Updates #24151

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb force-pushed the pr/lmb/ci-datapath-enable-acceleration-testing-only branch from ae56776 to 98ddd32 Compare April 5, 2023 12:51
@lmb
Copy link
Contributor Author

lmb commented Apr 5, 2023

Updated the commit description. If I understand correctly the setup I'm proposing would drop coverage of EP routes on, acceleration testing-only compared to Jenkins.

@lmb lmb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 5, 2023
@squeed squeed merged commit a4866b5 into master Apr 5, 2023
43 checks passed
@squeed squeed deleted the pr/lmb/ci-datapath-enable-acceleration-testing-only branch April 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/hyperjump feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants