New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: enable load balancer acceleration for some datapath conformance cases #24738
CI: enable load balancer acceleration for some datapath conformance cases #24738
Conversation
Use the same logic for EGRESS_GATEWAY as for other features. Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
c0446aa
to
ae0ed75
Compare
ae0ed75
to
3078784
Compare
ConformanceK8sKind flaked: #24622 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have re-run the flaky test, and it passed.
LGTM from the workflow perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you maybe add some quick context to the second commit on how we ended up with 6-7? (iirc the initial idea was 4-7 and 12-15, which are the ones with egressgw enabled but 12-15 have encryption enabled?)
3078784
to
ae56776
Compare
Set loadBalancer.acceleration=testing-only in two datapath conformance tests. I had originally planned to modify 12-15 but those have encryption enabled. Instead, enable it on 6-7. Compared to Jenkins we drop testing for (EP routes=true, acceleration=testing-only) from the matrix. Updates #24151 Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
ae56776
to
98ddd32
Compare
Updated the commit description. If I understand correctly the setup I'm proposing would drop coverage of EP routes on, acceleration testing-only compared to Jenkins. |
gh/workflows: enable loadBalancer acceleration for some suites
gh/workflows: fix initialization of EGRESS_GATEWAY