renovate: Add explicit gitAuthor #24739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimmlerd
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
If the name change is an issue, I think we can use gitmailmap to remap?
aanm
approved these changes
Apr 5, 2023
This commit adds an explicit gitAuthor to Renovate. The intent behind this is that it will match the author line in the `Signed-off-by` field: https://docs.renovatebot.com/presets-default/#gitsignoff This fixes an issue where previously checkpatch failed with the following error: ``` Error: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>' ``` Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/fix-renovate-signoff
branch
from
77a8d00
to
534d906
Compare
Thanks! I added a mailmap entry (and changed the Renovate config to keep using the old |
squeed
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an explicit gitAuthor to Renovate. The intent behind this is that it will match the author line in the
Signed-off-byfield:https://docs.renovatebot.com/presets-default/#gitsignoff
This fixes an issue where previously checkpatch failed with the following error:
Manually tested here:
renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>, new:Renovate Bot <bot@renovateapp.com>