Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate GKE workflow flake #24755

Merged
merged 1 commit into from Apr 5, 2023
Merged

Mitigate GKE workflow flake #24755

merged 1 commit into from Apr 5, 2023
+16 −8

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Apr 5, 2023

This commit mitigates workflow flake on GKE with tunnel installation until issue #22368 is fixed.
For the test with tunnel test namespace is added and for uninstall --wait option is removed.

@brlbil
Copy link
Contributor Author

brlbil commented Apr 5, 2023

I have run the tests for every version 6 times, a total of 24 times and all were successful and did not hit the flake once.

@brlbil
ci/workflow: mitigate GKE flake
a8b65e6 
This commit mitigates workflow flake on GKE with tunnel installation
until the issue #22368 is fixed.
For the test with tunnel test namespace is added
and for uninstall --wait option is removed.

Signed-off-by: Birol Bilgin <birol@cilium.io>
@brlbil brlbil force-pushed the pr/brlbil/ci-gke-mitigate branch from 8c2b77e to a8b65e6 Compare April 5, 2023 14:31
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 5, 2023
@brlbil brlbil marked this pull request as ready for review April 5, 2023 14:31
@brlbil brlbil requested review from a team as code owners April 5, 2023 14:31
@brlbil brlbil requested a review from nbusseneau April 5, 2023 14:32
pchaigno
pchaigno approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Birol!

(Completely unrelated: I don't think your cilium.io email is linked to your GitHub account.)

@pchaigno pchaigno added release-note/ci This PR makes changes to the CI. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Apr 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 5, 2023
@brlbil brlbil added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 5, 2023
@squeed squeed merged commit 5a864cb into master Apr 5, 2023
43 checks passed
@squeed squeed deleted the pr/brlbil/ci-gke-mitigate branch April 5, 2023 15:38
@pchaigno pchaigno mentioned this pull request Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau was automatically assigned from cilium/github-sec

Assignees
No one assigned
Labels
integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brlbil @pchaigno @squeed