Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix status reporting in the ci-multicluster test #24784

Merged
merged 1 commit into from Apr 13, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Apr 6, 2023

This PR applies the same changes introduced in #23865 to the ci-multicluster workflow, moving the status reporting after all matrix jobs are done. This prevents that the status reported by one job is later overwritten by a subsequent one.

Related: #23729

ci: fix status reporting in the ci-multicluster test 

This commit applies the same changes introduced in #23865 to the
ci-multicluster workflow, moving the status reporting after all matrix
jobs are done. This prevents that the status reported by one job is
later overwritten by a subsequent one.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 6, 2023
@giorio94
Copy link
Member Author

giorio94 commented Apr 6, 2023

Link to last successful run: https://github.com/cilium/cilium/actions/runs/4630200074
I've additionally tested this change in my fork with the /ci-multicluster trigger, and it also worked properly

@giorio94 giorio94 force-pushed the pr/giorio94/conformance-clustermesh-status branch from 4a70d3d to 4c77383 Compare April 6, 2023 15:13
@giorio94 giorio94 marked this pull request as ready for review April 6, 2023 15:13
@giorio94 giorio94 requested review from a team as code owners April 6, 2023 15:13
@giorio94 giorio94 requested a review from brlbil April 6, 2023 15:13
@giorio94
Copy link
Member Author

giorio94 commented Apr 7, 2023

Integration tests failed due to known flake #24696

Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giorio94
Copy link
Member Author

Marking as ready to merge, since reviews are in, and it is pointless to run the additional tests (as this PR affects a workflow only).

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 13, 2023
@dylandreimerink dylandreimerink merged commit 95e0919 into master Apr 13, 2023
43 checks passed
@dylandreimerink dylandreimerink deleted the pr/giorio94/conformance-clustermesh-status branch April 13, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants