Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: Enable ClusterFirstWithHostNet dnsPolicy conditionally #24803

Merged
merged 1 commit into from Apr 11, 2023
Merged

auth: Enable ClusterFirstWithHostNet dnsPolicy conditionally #24803

merged 1 commit into from Apr 11, 2023

Conversation

sayboras
Copy link
Member

This was overlooked in the below commit, my bad :(.

Relates: 6d9772a
Fixes: #24774

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2023
@sayboras
Copy link
Member Author

/ci-eks

@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. release-note/misc This PR makes changes that have no direct user impact. labels Apr 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2023
@sayboras sayboras added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed release-note/misc This PR makes changes that have no direct user impact. labels Apr 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 11, 2023
@sayboras sayboras added the area/servicemesh GH issues or PRs regarding servicemesh label Apr 11, 2023
@sayboras
Copy link
Member Author

/ci-eks

@sayboras sayboras marked this pull request as ready for review April 11, 2023 05:06
@sayboras sayboras requested review from a team as code owners April 11, 2023 05:06
@sayboras
Copy link
Member Author

/test

@sayboras
auth: Enable ClusterFirstWithHostNet dnsPolicy conditionally
f6f00fa 
This was overlooked in the below commit, my bad :(.

Relates: 6d9772a
Fixes: cilium#24774
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras
Copy link
Member Author

/test

joestringer
joestringer approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interests of fixing the main branch, this seems like a good immediate solution.

It'd be good to also revisit questions like 'does this mean that mTLS is incompatible with EKS?' and more generally 'how can we avoid chicken&egg scenarios in SPIRE cfg bootstrapping?' after as well.

@christarazi christarazi added kind/bug This is a bug in the Cilium logic. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Apr 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 11, 2023
@christarazi christarazi added release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Apr 11, 2023
@bimmlerd bimmlerd mentioned this pull request Apr 11, 2023
Merged
@sayboras
Copy link
Member Author

test-1.26-net-next was triggered twice as per below:

ci-datapath failure is happening in master branch as well https://github.com/cilium/cilium/actions/runs/4664037693. The change in this PR should not have any impact on datapath tests.

Marking this ready to merge to fix ci-eks failure in master.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 11, 2023
@sayboras sayboras mentioned this pull request Apr 11, 2023
Merged
2 tasks
@dylandreimerink dylandreimerink merged commit eac15b4 into cilium:master Apr 11, 2023
55 of 57 checks passed
@sayboras sayboras deleted the tam/debug-24774 branch April 11, 2023 11:23
@tklauser tklauser mentioned this pull request Apr 12, 2023
Merged
@mhofstetter mhofstetter mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@joestringer joestringer joestringer approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

@youngnick youngnick youngnick approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh kind/bug This is a bug in the Cilium logic. kind/regression This functionality worked fine before, but was broken in a newer release of Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
8 participants
@sayboras @gandro @joestringer @tommyp1ckles @youngnick @michi-covalent @dylandreimerink @christarazi