ci: Disable wireguard in v1.13 conformance datapath #24804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
area/CI
pippolo84
force-pushed
the
pr/pippolo84/fix-conformance-datapath-v1.13
branch
from
d6e4778
to
790faaf
Compare
pchaigno
requested changes
Apr 11, 2023
ci-datapath-1.13 workflow is failing in the configs with wireguard enable due to an incompatibility with the L7 proxy: `level=fatal msg="Wireguard (--enable-wireguard) is not compatible with L7 proxy (--enable-l7-proxy)" subsys=daemon` An example of that failure can be found here: https://github.com/cilium/cilium/actions/runs/4620306511/jobs/8170228050 All the workflow configs with wireguard enabled are changed to disable encryption. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/fix-conformance-datapath-v1.13
branch
from
790faaf
to
67f59ea
Compare
Thanks for the suggestion, I've changed it to disable encryption. |
pchaigno
approved these changes
Apr 11, 2023
pchaigno
added
area/encryption
brlbil
approved these changes
Apr 11, 2023
|
I'm confused, why are we only hitting this now? Do the datapath tests make use of L7 proxy? If not, then I think it might be the better option to disable L7 instead (which is what the Cilium CLI was supposed to do for v1.13 and older). (Having said that, I'm fine with merging this as is, to unblock the v1.13 branch.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci-datapath-1.13 workflow is failing in the configs with wireguard enable due to an incompatibility with the L7 proxy:
level=fatal msg="Wireguard (--enable-wireguard) is not compatible with L7 proxy (--enable-l7-proxy)" subsys=daemonAn example of that failure can be found here: https://github.com/cilium/cilium/actions/runs/4620306511/jobs/8170228050
All the workflow configs with wireguard enabled are changed to disable encryption.