Use cilium-cli latest stable version in conformance-datapath workflows #24809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pippolo84
added
area/CI
pippolo84
force-pushed
the
pr/pippolo84/fix-conformance-datapath
branch
2 times, most recently
from
dc4b5b5
to
4b26fc6
Compare
pippolo84
force-pushed
the
pr/pippolo84/fix-conformance-datapath
branch
from
4b26fc6
to
a200118
Compare
Currently, both conformance-datapath workflows are using the latest cilium-cli-ci images, built from the master branch. This recent cilium-cli commit: cilium/cilium-cli@0c03922 seems to be the culprit of the failures in the conformance workflows: `Error from server (BadRequest): error when creating "tmpl.yaml": DaemonSet in version "v1" cannot be handled as a DaemonSet: json: cannot unmarshal bool into Go struct field NodeSelectorRequirement.spec.template.spec.affinity.nodeAffinity.requiredDuringSchedulingIgnoredDuringExecution.nodeSelectorTerms.matchExpressions.values of type string` Since there is no need to use the cilium-cli built from the master branch, the version is changed to be the latest stable one. This will serve as a temporary fix for the workflows until the issue is addressed in the cilium-cli repository. Also, renovate is enabled in order to update cilium-cli version in the workflows as soon as a new stable version is released. Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
force-pushed
the
pr/pippolo84/fix-conformance-datapath
branch
from
a200118
to
30f799f
Compare
pippolo84
force-pushed
the
pr/pippolo84/fix-conformance-datapath
branch
from
9862359
to
c315af3
Compare
|
Example run of |
pchaigno
added
the
ready-to-merge
brlbil
approved these changes
Apr 11, 2023
sayboras
approved these changes
Apr 11, 2023
dylandreimerink
approved these changes
Apr 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, both conformance-datapath workflows are using the latest cilium-cli-ci images, built from the master branch. This recent cilium-cli commit:
cilium/cilium-cli@0c03922
seems to be the culprit of the failures in the conformance workflows:
Since there is no need to use the cilium-cli built from the master branch, the version is changed to be the latest stable one.
This will serve as a temporary fix for the workflows until the issue is addressed in the cilium-cli repository.
Also, renovate is enabled in order to update cilium-cli version in the workflows as soon as a new stable version is released.