ipsec, option: Make the IPsec key rotation delay configurable #24811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
release-note/minor
asauber
approved these changes
Apr 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
No. |
We currently have a maximum IPsec key rotation delay hardcoded to 5 minutes. After that time, we remove the old key from the node. Therefore, if the new key wasn't propagated to all nodes before then, communication between nodes will break. 5 minutes is usually enough because all agents will pick up the new key as soon as it's loaded and takes them a few seconds maximum to reload their IPsec configuration in the kernel. For clustermesh scenarios however, 5 minutes may not be enough. In those cases, the key needs to be updated separately on all clusters. Depending on the number of clusters and how this is done, it may take longer than 5 minutes. This commit therefore makes this 5 minutes delay configurable via an agent flag. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
configurable-ipsec-key-rotation-delay
branch
from
d178da2
to
52b5bc2
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
YutaroHayakawa
approved these changes
Apr 18, 2023
|
This is not covered in end-to-end tests and all compile & lint tests are passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a maximum IPsec key rotation delay hardcoded to 5 minutes. After that time, we remove the old key from the node. Therefore, if the new key wasn't propagated to all nodes before then, communication between nodes will break.
5 minutes is usually enough because all agents will pick up the new key as soon as it's loaded and takes them a few seconds maximum to reload their IPsec configuration in the kernel.
For clustermesh scenarios however, 5 minutes may not be enough. In those cases, the key needs to be updated separately on all clusters. Depending on the number of clusters and how this is done, it may take longer than 5 minutes.
This pull request therefore makes this 5 minutes delay configurable via an agent flag.