Remove sockops from eBPF datapath diagrams

[zacharysarah]

Fixes: #24735

docs: Remove sockops, sockmaps from eBPF datapath diagrams

[maintainer-s-little-helper]

Commit 55bae9865ad2c1bd5bc4cab2ff317138d9aac0f5 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[maintainer-s-little-helper]

Commit 55bae9865ad2c1bd5bc4cab2ff317138d9aac0f5 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

[qmonnet]

Thanks a lot! I have three comments:

• Sockmaps are gone as well, along with sockops. File bpf_redir.c was entirely removed in 87c8746. Could you please remove the corresponding boxes as well?

• The title of some diagrams refers to sockmaps and should also be updated. The version numbers as well, I suppose.

• Could we maybe adjust the size of the frames that contained the removed boxes on the diagrams (maybe narrow down the entire diagram by also moving the keys when relevant)? The resulting diagrams currently have frames with some empty spaces, just as if something in it was missing. This might be easier with an SVG editor rather than a text editor.

[zacharysarah]

@qmonnet 👋🏻

Sockmaps are gone as well, along with sockops. File bpf_redir.c was entirely removed in 87c8746. Could you please remove the corresponding boxes as well?

👍🏻

The title of some diagrams refers to sockmaps and should also be updated. The version numbers as well, I suppose.

👍🏻

Could we maybe adjust the size of the frames that contained the removed boxes on the diagrams

Exactly the point of my reviewer note in the OP. 🎯

This might be easier with an SVG editor rather than a text editor.

I've never actually edited an SVG with an SVG editor before. I welcome your recommendation about which editor you think would work best.

[zacharysarah]

@qmonnet 👋🏻 PTAL

[qmonnet]

Thanks! The diagrams look better now.

I've got a few comments on the second one (cilium_bpf_endpoint.svg):

• Should it be renamed v1.13 Datapath instead of v1.x? It's not clear to me why one is 1.x and the others have a fixed version number. Maybe I'm missing some context.

• Should we remove the bottom part of the diagram? Now that sockops/sockmaps have been removed from it, I'm not sure there's much interest in keeping that part.

Other than these, looks good to me.

I'll add a request review from Joe who has a good vision of the datapath and should be able to tell if we missed something that is outdated?

[zacharysarah]

@qmonnet 👋🏻

Should it be renamed v1.13 Datapath instead of v1.x?

I kept 1.x because it's unique in the current version (the others were 1.8). I'm happy to change it.

Should we remove the bottom part of the diagram?

That's my thought as well, but I didn't want to presume. @joestringer WDYT? 🙏🏻

UPDATE: I've made both changes. If you like them, please review accordingly. 🙇🏻‍♀️

[joestringer]

LGTM. I think we could follow up to add the bpf_sock logic for socket-level L4 LoadBalancing, but that can be a separate submission on top IMO.

[qmonnet]

Looks all good to me as well, thanks a lot for working on this!

[qmonnet]

Doc change only, with Documentation workflow passing. We have reviews from all code-owner teams (Anton was pulled for cilium/sig-datapath, but Joe and I are part of that team as well). I'm just changing the release-note label to misc as there's no functionality change, and marking as ready-to-merge.