Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lorenz Bauer to committers #24864

Merged
merged 1 commit into from Apr 14, 2023
Merged

Add Lorenz Bauer to committers #24864

merged 1 commit into from Apr 14, 2023

Conversation

xmulligan
Copy link
Member

@xmulligan xmulligan commented Apr 13, 2023

The voting period for granting to commit access to Lorenz Bauer (@lmb)
initiated on 2023-03-29 is now closed with the following results:
YES: 26 (58%)
NO: 0 (0%)
ABSTAIN: 9 (20%)
With the company block vote limit applied:
YES: (24 / (24/6)) + 2 = 8 votes
NO: 0 votes
Based on these results committer status is granted and Lorenz will be added to the list of Cilium maintainers at the CNCF

@xmulligan xmulligan requested a review from a team as a code owner April 13, 2023 11:10
@xmulligan xmulligan requested a review from bimmlerd April 13, 2023 11:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 13, 2023
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Apr 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 13, 2023
xmulligan added a commit to xmulligan/foundation that referenced this pull request Apr 13, 2023
cilium/cilium#24864

Signed-off-by: Bill Mulligan <pba_32@msn.com>
@xmulligan
Copy link
Member Author

cc: @lmb

MAINTAINERS.md Outdated Show resolved Hide resolved
@tklauser tklauser removed the request for review from bimmlerd April 13, 2023 20:44
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 13, 2023
@dylandreimerink dylandreimerink removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 14, 2023
@dylandreimerink
Copy link
Member

The commit message style triggers the CI:

  Warning: WARNING:BAD_SIGN_OFF: 'Co-authored-by:' is the preferred signature form
  #16: 
  Co-Authored-By: Tobias Klauser <tobias@cilium.io>

The voting period for granting to commit access to Lorenz initiated on 2023-03-29 is now closed with the following results:
YES: 26 (58%)
NO: 0 (0%)
ABSTAIN: 9 (20%)
With the company block vote limit applied:
YES: (24 / (24/6)) + 2 = 8 votes
NO: 0 votes
Based on these results committer status is granted and Lorenz will be added to the list of Cilium maintainers at the CNCF

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@joestringer
Copy link
Member

Filed #24904 for the integration tests failure.

@joestringer joestringer merged commit ec63ae9 into master Apr 14, 2023
42 of 43 checks passed
@joestringer joestringer deleted the add-lmb branch April 14, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants