bpf: nodeport: fix up trace point in to-overlay NAT paths #24886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a number of cases (EgressGW, DSR-GENEVE) where the to-overlay program is used even when the cluster is in native routing mode. But the trace points inside handle_nat_fwd() currently only report TRACE_TO_OVERLAY iff called from IS_BPF_OVERLAY *and* routing-mode=tunnel. Thus when in native routing mode, we get misleading trace notifications from inside to-overlay that report TRACE_TO_NETWORK. Fix this by only checking for IS_BPF_OVERLAY when selecting the obs_point. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
kind/bug
|
/test |
pchaigno
requested review from
YutaroHayakawa
and removed request for
NikAleksandrov
YutaroHayakawa
approved these changes
Apr 18, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a number of cases (EgressGW, DSR-GENEVE) where the
to-overlayprogram is used even when the cluster is in native routing mode.But the trace points inside
handle_nat_fwd()currently only reportTRACE_TO_OVERLAYiff called fromIS_BPF_OVERLAYandrouting-mode=tunnel. Thus when in native routing mode, we get misleading trace notifications from insideto-overlaythat reportTRACE_TO_NETWORK.Fix this by only checking for IS_BPF_OVERLAY when selecting the obs_point.