bpf/wireguard: always lookup src identity #24903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When WireGuard node encryption is enabled, src is never set. Therefore, the unguarded check in line 97 always evaluates to true and no traffic is encrypted. This commit fixes this bug by always looking up the src identity, independent of if WireGuard node encryption is enabled or not. Fixes: 17419c9 ("bpf/wireguard: Skip encryption for cluster-external traffic") Signed-off-by: Leonard Cohnen <lc@edgeless.systems>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
7 tasks
pchaigno
added
kind/bug
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.24-kernel-5.4/1777/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/1846/ If it is a flake and a GitHub issue doesn't already exist to track it, comment |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When WireGuard node encryption is enabled, src is never set. Therefore, the unguarded check in line 97 always evaluates to true and no traffic is encrypted.
This commit fixes this bug by always looking up the src identity, independent of if WireGuard node encryption is enabled or not.
Fixes: 17419c9 ("bpf/wireguard: Skip encryption for cluster-external traffic")
When WireGuard node encryption is enabled, src is never set. Therefore, the unguarded check in line 97 always evaluates to true and no traffic is encrypted.
This commit fixes this bug by always looking up the src identity, independent of if WireGuard node encryption is enabled or not.
I didn't (re-) add any tests, since they only recently were moved from
test/k8sinto the ci. Note, that the deleted WireGuard Pod2pod ecryption tests (intest/k8s/datapath_configuration) successfully find the issue by additionally enabling node encryption in the helm values.Note that this bug didn't make it into any release.