Replace integration_tests build tag with INTEGRATION_TESTS env
#24925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
ti-mo
force-pushed
the
tb/integration-tests-build-tag
branch
from
702224b
to
2309922
Compare
ti-mo
changed the title
integration_tests build tag with INTEGRATION_TESTS env
|
/test |
dylandreimerink
approved these changes
Apr 18, 2023
Following the pattern of privileged tests, support using the INTEGRATION_TESTS environment variable for enabling integration tests instead of build tags. Signed-off-by: Timo Beckers <timo@isovalent.com>
Similar to cilium#20769, remove the integration_tests build tag and gate integration tests using the INTEGRATION_TESTS env instead. This makes sure all code can be built with a single `go build` or `go test`, without being aware of the existence of the build tag. Editor tooling will resume to function without additional configuration, and linters will see the code once again. Signed-off-by: Timo Beckers <timo@isovalent.com>
Omitted enabling integration tests in some examples if it wasn't relevant to what the example was trying to showcase. Signed-off-by: Timo Beckers <timo@isovalent.com>
Linters would previously not see these errors unless they were run with the integration_tests build tag. Now the tag has been removed, these files have become visible again. Signed-off-by: Timo Beckers <timo@isovalent.com>
… tag Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/integration-tests-build-tag
branch
from
2309922
to
73fae19
Compare
|
/test |
rolinh
approved these changes
Apr 18, 2023
YutaroHayakawa
approved these changes
Apr 18, 2023
christarazi
approved these changes
Apr 18, 2023
zacharysarah
approved these changes
Apr 18, 2023
aanm
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #20769, remove the integration_tests build tag and gate integration tests using the INTEGRATION_TESTS env instead.
This makes sure all code can be built with a single
go buildorgo test, without being aware of the existence of the build tag. Editor tooling will resume to function without additional configuration, and linters will see the code once again.Omitted enabling integration tests in some examples if it wasn't relevant to what the example was trying to showcase.
cc @oblazek