Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add CPU panel to Hubble L7 HTTP Workload dashboard #24934

Merged
merged 1 commit into from Apr 25, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Apr 17, 2023

CPU load is can be help to diagnose changes in request latency, so add a CPU panel next to the HTTP request duration panel.

This does use a recording rule metric node_namespace_pod_container:container_cpu_usage_seconds_total:sum_irate and namespace_workload_pod:kube_pod_owner:relabel from kube-prometheus. If a user is not using kube-prometheus, then they can copy the recording rule into their installation if they do not already have it.

helm: Add CPU panel to Hubble L7 HTTP Workload dashboard

Here's what the new panel looks like. There is also one in the row below for CPU utilization by destination.

Screenshot 2023-04-17 at 1 50 49 PM

@chancez chancez added kind/enhancement This would improve or streamline existing functionality. area/helm Impacts helm charts and user deployment experience labels Apr 17, 2023
@chancez chancez requested a review from a team as a code owner April 17, 2023 20:54
@chancez chancez self-assigned this Apr 17, 2023
@chancez chancez requested a review from a team as a code owner April 17, 2023 20:54
@chancez chancez requested a review from squeed April 17, 2023 20:54
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 17, 2023
@chancez chancez force-pushed the pr/chancez/hubble_l7_dashboard_cpu_panel branch from 65356a2 to 012de47 Compare April 17, 2023 20:58
CPU load is can be help to diagnose changes in request latency, so add a
CPU panel next to the HTTP request duration panel.

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez force-pushed the pr/chancez/hubble_l7_dashboard_cpu_panel branch from 012de47 to 89c2dd1 Compare April 17, 2023 21:02
@chancez chancez added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 18, 2023
@chancez chancez requested a review from lambdanis April 19, 2023 17:34
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chancez chancez added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 24, 2023
@michi-covalent michi-covalent merged commit 532590e into main Apr 25, 2023
43 checks passed
@michi-covalent michi-covalent deleted the pr/chancez/hubble_l7_dashboard_cpu_panel branch April 25, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants