api: Add libraries to Pascalify API endpoints #24967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
joestringer
force-pushed
the
pr/joe/api-flags-lib
branch
from
3c7f138
to
ff8bfa6
Compare
joestringer
force-pushed
the
pr/joe/api-flags-lib
branch
from
ff8bfa6
to
ce7c286
Compare
|
Travis hit issues connecting to ubuntu apt repos, closing+reopening to fix |
We have various APIs defined in the Swagger specification, each of which
has a range of API endpoints like "GET /endpoint", "DELETE /ipam/{ip}",
etc. In order to make these endpoints easier to refer to in a consistent
manner, introduce new api library functions that consume a go-openapi
spec and generate PascalCase flags for each API. Add some additional
useful functions that can be used for the purpose of restricting the
accessibility of certain APIs based on this PascalCase configuration.
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/api-flags-lib
branch
from
ce7c286
to
e8440eb
Compare
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.19/992/ If it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
k8s-1.16-kernel-4.19 job hit known flake #24840. |
|
/test-1.16-4.19 |
nathanjsweet
approved these changes
Apr 20, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have various APIs defined in the Swagger specification, each of which
has a range of API endpoints like "GET /endpoint", "DELETE /ipam/{ip}",
etc. In order to make these endpoints easier to refer to in a consistent
manner, introduce new api library functions that consume a go-openapi
spec and generate PascalCase flags for each API. Add some additional
useful functions that can be used for the purpose of restricting the
accessibility of certain APIs based on this PascalCase configuration.
As a demonstration example of the pascalized strings, see the following (incomplete) table of APIs:
This will be used by #24661 in order to allow the user to configure which API endpoints are exposed by the cilium-agent API server. See also #24968 for an example of how to use these libraries to generate a description of API flags.