bpf: init.sh: rename TUNNEL_MODE variable to TUNNEL_PROTOCOL #24969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datapath uses the TUNNEL_MODE macro to determine whether routing is direct or via a tunnel. TUNNEL_MODE is *not* set in a direct-routing config with ad-hoc tunnel for eg. EgressGW. The TUNNEL_MODE shell variable in init.sh contains the actual protocol of the tunnel (vxlan or geneve), and is also set for an ad-hoc tunnel. Avoid any confusion when reading the code, by renaming the shell variable to the more fitting TUNNEL_PROTOCOL. Do the same thing in the agent code that calls the script. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
julianwiedmann
added
sig/datapath
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datapath uses the TUNNEL_MODE macro to determine whether routing is direct or via a tunnel. TUNNEL_MODE is not set in a direct-routing config with ad-hoc tunnel for eg. EgressGW.
The TUNNEL_MODE shell variable in init.sh contains the actual protocol of the tunnel (vxlan or geneve), and is also set for an ad-hoc tunnel.
Avoid any confusion when reading the code, by renaming the shell variable to the more fitting TUNNEL_PROTOCOL. Do the same thing in the agent code that calls the script.