statedb: Fix WriteJSON with multiple tables #24970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
bimmlerd
approved these changes
Apr 19, 2023
joamaki
force-pushed
the
pr/joamaki/statedb-fix-writejson
branch
from
cb0a5a0
to
2836a0e
Compare
WriteJSON produced broken JSON with multiple tables. This refactors it to use a buffered writer and extends the tests to check that it works with two tables instead of just one. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/statedb-fix-writejson
branch
from
2836a0e
to
7bd3019
Compare
Cleaned up the error handling. |
ti-mo
approved these changes
Jun 1, 2023
joamaki
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriteJSON produced broken JSON with multiple tables. This refactors it to use a buffered writer and extends the tests to check that it works with two tables instead of just one.