conformance-k8s-kind: disable kindnet, enable log dumping #24982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging a test failure, I noticed that this workflow missed disabling the kindnet CNI (every other workflow already does this). Separately, enable log dumping on failure, otherwise there isn't enough to go on when tests fail. Signed-off-by: Casey Callendrello <cdc@isovalent.com>
squeed
added
area/CI
|
fyi @aojea, as the author of this job, you might be interested. |
|
The affected job has passed. I'm going to re-trigger it in an attempt to get a failure :-). |
|
/lgtm |
brlbil
approved these changes
Apr 20, 2023
|
marking as ready-to-merge; the only failing test is a different github run and there's no point in running Jenkins. |
squeed
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a test failure, I noticed that this workflow missed disabling the kindnet CNI (every other workflow already does this).
Separately, enable log dumping on failure, otherwise there isn't enough to go on when tests fail.