Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpv1: initialize service announcement map on reinit #24985

Merged
merged 1 commit into from
Apr 20, 2023
Merged

bgpv1: initialize service announcement map on reinit #24985

merged 1 commit into from
Apr 20, 2023

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Apr 19, 2023 •
edited

On modification to BGP global parameters like router-id, we reinitialize BGP server config. This change initializes ServiceAnnouncements map correctly to fix panic in subsequent writes to it.

Fixes: #24975

Fix panic due to assignment to nil BGP service announcements map.

@harsimran-pabla
bgpv1: make service announcement map on reinit
ded06d7 
On modification to BGP global parameters like router-id, we reinitialize
bgp server config. This change initializes ServiceAnnouncements map correctly
to fix panic in subsequent writes to it.

Fixes: cilium#24975

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner April 19, 2023 16:27
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2023
@harsimran-pabla harsimran-pabla removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2023
@joestringer joestringer added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Apr 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 19, 2023
@joestringer
Copy link
Member

Could you add affects/* labels for all affected versions? Additionally, according to the backporting criteria this is likely at least eligible for automatic backport to 1.13, so maybe you could also add needs-backport/1.13 label?

@harsimran-pabla harsimran-pabla added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch affects/v1.13 This issue affects v1.13 branch kind/bug This is a bug in the Cilium logic. labels Apr 19, 2023
@harsimran-pabla harsimran-pabla changed the title bgpv1: intitialize service announcement map on reinit bgpv1: initialize service announcement map on reinit Apr 19, 2023
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla
Copy link
Contributor Author

/test-1.27-net-next

ldelossa
ldelossa approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 20, 2023
@ldelossa ldelossa merged commit 74e4195 into cilium:main Apr 20, 2023
43 checks passed
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
15 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 20, 2023
@sayboras sayboras added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 26, 2023
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
affects/v1.13 This issue affects v1.13 branch backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrading 1.13.1 to 1.13.2 - panic: assignment to entry in nil map
5 participants
@harsimran-pabla @joestringer @ldelossa @nbusseneau @sayboras