Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/contributing: update CRD registration instructions #25008

Merged
merged 1 commit into from Apr 21, 2023

Conversation

tklauser
Copy link
Member

The create*CRD funcs are no longer needed after commit af68df7 ("operator: cleanup CRD registration"). Instead createCRD with the appropriate arguments should be used.

The create*CRD funcs are no longer needed after commit af68df7
("operator: cleanup CRD registration"). Instead createCRD with the
appropriate arguments should be used.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Apr 20, 2023
@tklauser tklauser requested review from a team as code owners April 20, 2023 16:12
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective 👍🏻

Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❇️

@tklauser
Copy link
Member Author

This is docs-only PR and the docs build passed: https://deploy-preview-25008--docs-cilium-io.netlify.app/ All reviewers approved. Marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 21, 2023
@ldelossa ldelossa merged commit df61913 into cilium:main Apr 21, 2023
36 checks passed
@tklauser tklauser deleted the pr/tklauser/k8s-crd-docs branch April 21, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants