Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: Include Cilium NetworkPolicies in Envoy Config Dump #25028

Merged
merged 2 commits into from Apr 26, 2023

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Apr 21, 2023

This commit updates the Cilium Proxy docker image to the latest version (797bea843de17da8f8a096747c4691405b540aa8).

This provides the enhancement that Cilium NetworkPolicies are now part of Envoys Config Dump and therefore part of Ciliums SysDump (cilium/proxy#184)

Cilium L7 Proxy: Envoy config dump contains Cilium network policies

@mhofstetter mhofstetter added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Apr 21, 2023
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/cilium-proxy-update branch from ecc1464 to 6bbb184 Compare April 21, 2023 06:42
@mhofstetter mhofstetter marked this pull request as ready for review April 21, 2023 06:56
@mhofstetter mhofstetter requested review from a team as code owners April 21, 2023 06:56
@mhofstetter mhofstetter marked this pull request as draft April 21, 2023 06:58
@mhofstetter mhofstetter changed the title Proxy: Update Envoy Proxy (cilium/proxy) to latest v1.25 based version Proxy: Include Cilium NetworkPolicies in Envoy Config Dump Apr 21, 2023
@mhofstetter mhofstetter added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/servicemesh GH issues or PRs regarding servicemesh labels Apr 21, 2023
This commit updates the Cilium Proxy docker image to the latest version
with underlying Envoy 1.25 (`797bea843de17da8f8a096747c4691405b540aa8`).

It comes with the following changes / new features:

* Support Ingress ID also for east/west Ingress cilium/proxy#167
* admin: include cilium networkpolicies in envoy config dump
  cilium/proxy#184
* patches: Update for upstreamed versions cilium/proxy#183

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit updates the latest Cilium Proxy API matching.

It includes the following changes / new features:

* Support Ingress ID also for east/west Ingress cilium/proxy#167
* admin: include cilium networkpolicies in envoy config dump cilium/proxy#184
* patches: Update for upstreamed versions cilium/proxy#183

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/cilium-proxy-update branch from 6bbb184 to e871841 Compare April 25, 2023 09:23
@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter marked this pull request as ready for review April 25, 2023 10:01
@mhofstetter mhofstetter requested review from rolinh, nebril and sayboras and removed request for a team April 25, 2023 10:01
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️.

For other reviewer, the digest is coming from https://github.com/cilium/proxy/actions/runs/4757816249/jobs/8455099808

@mhofstetter
Copy link
Member Author

marking this as ready-to-merge - with the main intention to bring this into v1.14.0-snapshot.2

@sayboras already covered all SIGS (vendor & build)

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@sayboras sayboras changed the title Proxy: Include Cilium NetworkPolicies in Envoy Config Dump envoy: Include Cilium NetworkPolicies in Envoy Config Dump Apr 26, 2023
@sayboras sayboras merged commit 5d0ee60 into cilium:main Apr 26, 2023
56 checks passed
@mhofstetter mhofstetter deleted the pr/mhofstetter/cilium-proxy-update branch April 26, 2023 06:48
@sayboras
Copy link
Member

Merged and thanks ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants