Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon/cmd: fix a couple of func doc string #25030

Merged
merged 1 commit into from Apr 28, 2023
Merged

daemon/cmd: fix a couple of func doc string #25030

merged 1 commit into from Apr 28, 2023

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Apr 21, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Fixes: #issue-number

<!-- Enter the release note text here if needed or remove this section! -->

@cuishuang cuishuang requested review from a team as code owners April 21, 2023 08:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 21, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 21, 2023
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cuishuang thanks for the PR and good catch.

Could you please rephrase the commit message and PR title to something a tad more descriptive? e.g. "daemon/cmd: fix a couple of func doc string"

@kaworu kaworu added kind/cleanup This includes no functional changes. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Apr 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 21, 2023
@cuishuang cuishuang changed the title fix some comments daemon/cmd: fix a couple of func doc string Apr 21, 2023
@cuishuang
Copy link
Contributor Author

@cuishuang thanks for the PR and good catch.

Could you please rephrase the commit message and PR title to something a tad more descriptive? e.g. "daemon/cmd: fix a couple of func doc string"

Of course!Done

@kaworu
Copy link
Member

kaworu commented Apr 21, 2023

@cuishuang Thanks for the update, please change the commit message as well, you can do it with

% git commit --amend
% git push --force-with-lease

@cuishuang
Copy link
Contributor Author

@cuishuang Thanks for the update, please change the commit message as well, you can do it with

% git commit --amend
% git push --force-with-lease

Thanks! Done

Signed-off-by: cui fliter <imcusg@gmail.com>
@kaworu
Copy link
Member

kaworu commented Apr 28, 2023

generate-k8s-api CI failure is unrelated to the patch (opened #25192 to workaround the issue), all other checks are green and reviews in (no need for a full CI run) so marking as ready-to-merge.

@kaworu kaworu added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 28, 2023
@pchaigno pchaigno merged commit 1d867d0 into cilium:main Apr 28, 2023
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. kind/cleanup This includes no functional changes. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants