makefile: introduce variable CILIUM_CLI for cilium cli binary #25031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofstetter
added
release-note/misc
|
/test |
jibi
approved these changes
May 3, 2023
Currently, cilium cli binary usage is hardcoded in various make targets to `cilium` - which often is the latest stable Cilium CLI version. This commit introduces a make variable `CILIUM_CLI` which is used in all these places and defaults to `cilium`. This way, it's easily possible to switch to another Cilium CLI version - e.g. to use and test newer cilium cli features (e.g. helm mode). Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
This commit adds the make target `kind-uninstall-cilium` which can be used to uninstall cilium from the local kind cluster. This is especially handy in combination with the newly introduces CILIUM_CLI. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/make-cilium-cli-enhancements
branch
from
52cc989
to
7283a87
Compare
|
rebased to |
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cilium cli binary usage is hardcoded in various make targets to
cilium- which often is the latest stable Cilium CLI version.This commit introduces a make variable
CILIUM_CLIwhich is used in all these places and defaults tocilium.This way, it's easily possible to switch to another Cilium CLI version - e.g. to use and test newer cilium cli features (e.g. helm mode).
In addition make target
kind-uninstall-ciliumhas been added - which help to uninstall a previously installed installation with the same Cilium CLI and feature set.